search

microsoft / ConcordExtensibilitySamples

Visual Studio Debug Engine Extensibility Samples
Other
122 stars 50 forks source link

VS 2017 support part 1 #34

Closed gregg-miskelly closed 7 years ago

gregg-miskelly commented 7 years ago

With this commit, the "Hello World" projects should now work in VS 2017 RC3 (and probably older versions too). This is also the first part of support in the IrisExtension. But the fix for that one is more complicated as there are breaking changes in System.Reflection.Metadata. So I don't know if it will even be possible to use the same expression compiler in both (unless of course it didn't use System.Reflection.Metadata).

msftclas commented 7 years ago

Hi @gregg-miskelly, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Gregg Miskelly). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

plnelson commented 7 years ago

LGTM In terms of System.Reflection.Metadata, I've also looked into it and came to the conclusion that we'll need to simply port it to Dev15 when ready and lose backward compatibility. This should be fine because the current version is pre-release and Dev15 can use the released System.Reflection.Metadata.