search

microsoft / ConversationLearner-SDK

An SDK for ConversationLearner. REPOSITORY MOVED
https://github.com/microsoft/conversationlearner
MIT License
26 stars 9 forks source link

fix: various refactorings to before we fix hierarchy #490

Closed mattmazzola closed 5 years ago

mattmazzola commented 5 years ago

remove redundant logic in GetRunningApp

There was duplicate code for loading app based on this.configModelId

rename memoryStorage to storage

I'm guessing at one point it was named that because it was hardcoded to MemoryStorage. We allow providing any storage provider and it might not be memory. Example of FileStorage, RedisStorage, etc.

rename CLMemory to CLStorage

Better implies wrapper around BB.Storage. Still need to find plan to remove SetAppAsync as that is higher level concept.

rename BotMemory to EntityState

Better implies the difference from BotState. Instead of comparing BotState to BotMemory which implies the difference is with Memory vs State it's now EntityState vs BotState which implies difference is the storage of entities vs bot state.

Normalize the three types of state

BotState, EntityState, MessageState

Rename conversationId to activityId

The InputQueue variables were named conversationId even though it wasn't, this was extremely misleading given that there are actual conversation ids.

mattmazzola commented 5 years ago

:tada: This PR is included in version 0.326.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: