search

microsoft / CopilotStudioSamples

MIT License
332 stars 268 forks source link

SSO is not working for new PVA Bots #90

Open aksridhar opened 2 years ago

aksridhar commented 2 years ago

I have been using PVA Bots with SSO Javascript implementation and it has been working fine so far. I created a couple of new bots and followed the same steps with AAD App registration and PVA but SSO does not seem to be working. Not sure if recently something has changed in the way SSO is handled in PVA.

I tried with ReactWebchat as well and I see that SSO works fine with existing PVA Bot and Azure AD App. It keeps prompting for login when used with my new PVA and new AAD App.

Appreciate if someone can shed some light on any recent changes that could break SSO

iMicknl commented 1 year ago

@aksridhar have you been able to resolve this already? I am currently working on improving the SSO sample in this repository and I didn't face any issues.

Please let me know if you still face issues, otherwise we will close this issue.

aksridhar commented 1 year ago

Hi @iMicknl Thanks for checking. As I have mentioned Javascript version works perfectly fine. I am still having issue using Direct line secret and using the react version of webchat. It somehow does not perform the sign in. I tried using the same javascript code for the token exchange but somehow this is not working. It always prompts with login - https://learn.microsoft.com/en-us/power-virtual-agents/configure-sso

iMicknl commented 1 year ago

If you still face issues with new chatbots, best is to create a support ticket. Through this repository we won't be able to help you debug your issue with SSO and Power Virtual Agents.

Recently I have added a new pull request (https://github.com/microsoft/PowerVirtualAgentsSamples/pull/94) which has a more modern version of the SSO HTML/JS sample.

aksridhar commented 1 year ago

Hello @iMicknl . I did raise a ticket with Microsoft but they asked me to reach out to community as they were not able to help. I raised a similar question on Azure Bot Dev Github community also. It is being looked into. Do you have any working code that uses React webchat instead of webchat.js and that uses Direct line secrets?

adilei commented 10 months ago

@aksridhar, is this still an issue for you? I've been setting up SSO for new copilots/bots so I don't think anything is broken.

Are you able to repro this using the SSO sample in this repo?

aksridhar commented 10 months ago

Hi @adilei Thanks for following up. I had put this project on hold due to other priorities. I will have to revisit this thread again. Will keep you posted.

adilei commented 10 months ago

Whenever you're ready 😊