microsoft / CromwellOnAzure

Microsoft Genomics implementation of the Broad Institute's Cromwell workflow engine on Azure
MIT License
134 stars 55 forks source link

Changes required for Illumina DRAGEN support #317

Open vigunase opened 2 years ago

vigunase commented 2 years ago

Note: this requires more requirements gathering and review.

  1. Consider adding a generic backend_parameter called "docker_host_configuration", with value "dragen_v1.0.0"
  2. Create a new folder in the default storage accounts "configuration" container, called "docker_host_configuration" with a file named "dragen_v1.0.0.txt" in it (blob name: docker_host_configuration/dragen_v1.0.0.txt)
  3. The sample file shall contain settings including any/all of the following:

start_task_url docker_run_parameters batch_image_offer batch_image_publisher batch_image_sku batch_image_version batch_node_agent_sku_id

Notes on each of these:

Also consider:

BMurri commented 2 years ago

This requires more work

olesya13 commented 2 years ago

Depends on https://github.com/Azure/Batch/issues/131

vsmalladi commented 1 year ago

@BMurri https://github.com/Azure/Batch/issues/131 has been closed and resolved. Can we move this to 4.0 release?

BMurri commented 1 year ago

@vsmalladi I don't think it will make 4.0 (unless we continue to stretch it out) but it definitely should be in 4.1 IMO.

I need to migrate the PRs contents into the new multi-repo structure we now have, and rebase it on all the latest changes. That's going to take a bit of time.

vsmalladi commented 1 year ago

@BMurri Okay cool. Lets aim for 4.1 then.

ngambani commented 9 months ago

@vsmalladi @BMurri this looks like a long pending issue open since 2021, are we actively working on this or can this be closed?

BMurri commented 9 months ago

@ngambani I'm pretty sure DRAGEN in CoA is dead at this point but @vsmalladi would know that situation more. I linked this with the GPU and NVMe issues to remind me of the generalized structure I had built (and never merged) for this issue because a somewhat lighter weight version would facilitate both of those issues especially if we did them together. That's the same reason I haven't closed the branch associated with this issue (to more easily reuse parts rather than completely recreate the solution).

vsmalladi commented 9 months ago

I would like to add this funtionality. Let me circle with Illumina. @BMurri can we add this general functionality to coa/tes?

BMurri commented 9 months ago

@vsmalladi depends on them. We need some sort of supported docker image that includes the tools. Note that Azure has retired CentOS 7 AFAIK so this will require some work on their part, honestly. It's OK by me if they require public internet access (aka no support for completely private task compute node deployments) but they would need to specify the minimum port & domain-or-ip-addresses that would have to be permitted for the compute nodes to access (to ensure those who wish to deploy with this can set it up).

vsmalladi commented 8 months ago

They want to release this. Will have a technical dive with Illumina for what is needed.