Microsoft Genomics implementation of the Broad Institute's Cromwell workflow engine on Azure
MIT License
134
stars
55
forks
source link
Deployer: Impossible conflicts between `BatchNodesSubnetId` and `BatchSubnetName` disable ability to create new working private network deployments (*regression*) #806
Describe the bug
Private network deployments currently require that the BatchNodesSubnetId be supplied, but that results in a Virtual network '<name-of-virtual-network>' does not contain subnet '' validation failure, while supplying the BatchSubnetName instead (when the virtual network exists prior to running the deployer, required for private networking) results in TES not receiving the batch node subnet resource id (which is required by the batch account in that configuration).
Describe the bug Private network deployments currently require that the
BatchNodesSubnetId
be supplied, but that results in aVirtual network '<name-of-virtual-network>' does not contain subnet ''
validation failure, while supplying theBatchSubnetName
instead (when the virtual network exists prior to running the deployer, required for private networking) results in TES not receiving the batch node subnet resource id (which is required by the batch account in that configuration).Steps to Reproduce
Expected behavior A successful deployment.
Additional context I am assuming some merge dropped the previous working code. TES also suffers from this issue.