microsoft / CromwellOnAzure

Microsoft Genomics implementation of the Broad Institute's Cromwell workflow engine on Azure
MIT License
134 stars 55 forks source link

Deployer: Impossible conflicts between `BatchNodesSubnetId` and `BatchSubnetName` disable ability to create new working private network deployments (*regression*) #806

Closed BMurri closed 2 months ago

BMurri commented 3 months ago

Describe the bug Private network deployments currently require that the BatchNodesSubnetId be supplied, but that results in a Virtual network '<name-of-virtual-network>' does not contain subnet '' validation failure, while supplying the BatchSubnetName instead (when the virtual network exists prior to running the deployer, required for private networking) results in TES not receiving the batch node subnet resource id (which is required by the batch account in that configuration).

Steps to Reproduce

  1. Follow the directions.
  2. Observe the validation failure.

Expected behavior A successful deployment.

Additional context I am assuming some merge dropped the previous working code. TES also suffers from this issue.

BMurri commented 2 months ago

Fixed via microsoft/ga4gh-tes#774 and #807 and included in 5.4.2