microsoft / CsWin32

A source generator to add a user-defined set of Win32 P/Invoke methods and supporting types to a C# project.
MIT License
2.06k stars 86 forks source link

Regression - Null static property not generated for `HDC` in v0.3.106 (Stable) #1258

Closed adammw closed 2 days ago

adammw commented 1 month ago

Actual behavior

HDC.Null is not generated

Expected behavior

HDC.Null is generated

Repro steps

  1. NativeMethods.txt content:

    EnumDisplayMonitors
  2. Any of your own code that should be shared?

Context

Tested working again in v0.3.136 Daily build

Wondering if this is a consequence of it being silently broken in stable release, and https://github.com/microsoft/CsWin32/commit/f9aefcc5afe69c792e4c57d36f903e2d5d87176d inadvertently fixing it.

oold commented 3 weeks ago

I just noticed this after updating the metadata package. HWND has lost its IsNull property.

P.S.: I'm on an older version of CsWin32.

AArnott commented 2 days ago

Null and IsNull are indeed working in the latest CI builds, so I'm closing this.