FlagsAttribute missing for VARENUM - Githubissues

microsoft / CsWin32

A source generator to add a user-defined set of Win32 P/Invoke methods and supporting types to a C# project.

MIT License

2.1k stars 90 forks source link

FlagsAttribute missing for VARENUM #806

Closed harborsiem closed 1 year ago

harborsiem commented 1 year ago

Actual behavior

The VARENUM should have a FlagsAttribute because one can define VT_VECTOR | VT_UI4 for example

Expected behavior

The VARENUM should be marked with ` [Flags]
public enum VARENUM : ushort { ...

`

Repro steps

NativeMethods.txt content:
```
VARENUM
```
NativeMethods.json content (if present):
Any of your own code that should be shared?

Context

CsWin32 version: [0.2.138-beta+f3247a3e2a]
Win32Metadata version (if explicitly set by project):
Target Framework: [net6-windows]
LangVersion (if explicitly set by project): [e.g. 9]

harborsiem commented 1 year ago

The problem occurs with the ToString method. It needs extra work without the FlagsAttribute.

It is not really Flags