microsoft / CsWin32

A source generator to add a user-defined set of Win32 P/Invoke methods and supporting types to a C# project.

MIT License

2.06k stars 87 forks source link

Please don't add cast operators to System.Drawing types when System.Drawing is not installed #934

Closed wherewhere closed 1 year ago

wherewhere commented 1 year ago

Actual behavior

Expected behavior

Don't generate it when System.Drawing is not installed. It will be better if it can generate cast operators to Windows.Foundation

Repro steps

NativeMethods.txt content:
```
RECT
```

Context

CsWin32 version: 0.2.229-beta
Win32Metadata version (if explicitly set by project): 49.0.21-preview
Target Framework: uap10.0, netstandard1.1
LangVersion (if explicitly set by project): 11

wherewhere commented 1 year ago

626

AArnott commented 1 year ago

We should be able to suppress generation of these when the types it references aren't included in the compilation. Windows.Foundation cast operations is an option we could do when those types exist in the compilation as well.