microsoft / DLWorkspace

Deep Learning Workspace
Other
202 stars 75 forks source link

Incorrect override of __get_job_log_legacy by __extract_job_log_legacy #1242

Open Anbang-Hu opened 4 years ago

Anbang-Hu commented 4 years ago

https://github.com/microsoft/DLWorkspace/blob/bf6840f6f74db2cfb3fdab2939cdaeec8fe26e7e/src/ClusterBootstrap/template/RestfulAPI/config.yaml#L83

https://github.com/microsoft/DLWorkspace/blob/27d3a3a82e59305bdc67dbfd69098d493f8b3cd5/src/utils/JobRestAPIUtils.py#L662

If __get_job_log_legacy is false in config.yaml, its value is overriden by __extract_job_log_legacy.