search

microsoft / DSCParser

Allows the conversion of DSC scripts into PSObject for analysis purposes
MIT License
29 stars 20 forks source link

ConvertTo-DscObject hangs #16

Open SebastianGoers opened 3 years ago

SebastianGoers commented 3 years ago

Using ConvertTo-DscObject with PS 5.1 hangs due to an infinite loop in the code. I believe the issue results from https://github.com/microsoft/DSCParser/blob/383f56cd8aec757d28e8d14b6b39220a8f59ae70/Modules/DSCParser.psm1#L85 as in the while statement $i gets incremented which is also used in the for loop https://github.com/microsoft/DSCParser/blob/383f56cd8aec757d28e8d14b6b39220a8f59ae70/Modules/DSCParser.psm1#L52 and thus the for-loop never terminates. Also, there seems to be a change in the actual behavior in PS. It is documented here: https://github.com/microsoft/DSCParser/issues/15.

PrzemyslawKlys commented 2 years ago

@SebastianGoers it seems this is no longer a problem and your problem is solved?

mpiederiet commented 2 years ago

@PrzemyslawKlys I would say "yes it looks to be solved" as the referenced PR did include code to end the infinite loop. Close this one and when my PR is merged there will be no more open issues for this repo :-)