microsoft / DacFx

DacFx, SqlPackage, and other SQL development libraries enable declarative database development and database portability across SQL versions and environments. Share feedback here on dacpacs, bacpacs, and SQL projects.
https://aka.ms/sqlpackage-ref
MIT License
356 stars 20 forks source link

Treat CodeAnalysis Errors as Build errors, not IntelliSense #529

Open mrlmachado opened 5 days ago

mrlmachado commented 5 days ago

Is your feature request related to a problem? Please describe. I'm very happy to have a new parameter for SqlCodeAnalysis task, where we can specify a custom path to locate our custom rules DLLs, SqlCodeAnalysisAssemblyPaths and I think it's amazing how it works. But all the errors now are not being thrown as build errors in my case, but as IntelliSense errors, during VS build/rebuild command (devenv.exe /build)

This is a problem, because with previous versions of Microsoft.Data.Tools.MSBuild I could install the custom rules DDLs inside VS SQLDB DAC folder and it would throw code analysis errors as build errors, using MSBuild command line. Now, with the errors being thrown as IntelliSense errors, I cannot use msbuild command line anymore to validate my solution.

Describe the solution you'd like Code Analysis rules errors to be thrown as build errors, not IntelliSense errors.

Describe alternatives you've considered Using older versions of DataTools + DacFx does the trick, but I'd like to use the more recent versions of DacFx and have the SqlCodeAnalysisAssemblyPaths parameter as an option for MSBuild.

Additional context