microsoft / Data-Discovery-Toolkit

A data discovery and manipulation toolset for unstructured data
Other
52 stars 12 forks source link

Making deployment instructions in vars.sample more clear on new resources which will be created #14

Open sushaanttb opened 1 year ago

sushaanttb commented 1 year ago

In the deployment steps, when trying to configure the vars.env as per the provided instructions, it looks like that Synapse instance should already be created beforehand. Please refer attached screenshot.

In a way this gives an impression to the user that this toolkit will deploy some visualization solution based on existing resources and the user will thus first try to create those resources manually and then will come back here to fill those details, which is not the case as the deploy.sh is taking care of creating all those resources.

Hence, it would be immensely helpful if we can clarify the same in our instructions i.e. resources which should be pre-existing & resources which deploy.sh will create.

MicrosoftTeams-image
shanepeckham commented 1 year ago

Thanks @sushaanttb , could you please raise a PR and address? Thank you!