search

microsoft / Data-Science-For-Beginners

10 Weeks, 20 Lessons, Data Science for All!
https://microsoft.github.io/Data-Science-For-Beginners/
MIT License
28.05k stars 5.79k forks source link

The x and y labels in the PNG images are not readable when using a dark theme setting #298

Closed flegaspi700 closed 2 years ago

flegaspi700 commented 2 years ago

Describe the bug The x and y labels in the PNG images in the link below are not readable when using a dark theme setting. https://github.com/microsoft/Data-Science-For-Beginners/tree/main/3-Data-Visualization/09-visualization-quantities

To Reproduce Steps to reproduce the behavior: View the page using a dark theme. Go to profile -> Settings -> Appearance -> Select Dark Default or Dark Dimmed in Theme Preference -> Reload the Visualization Quantities page

Expected behavior PNG images must be generated with "facecolor='white'", for the ONG images to be readable for both Light and Dark theme.

Screenshots If applicable, add screenshots to help explain your problem. Screenshot sample using Dark Dimmed setting. image

I was able to test this in my repository using new PNG images. https://github.com/flegaspi700/Data-Science-For-Beginners/tree/main/3-Data-Visualization/09-visualization-quantities

jlooper commented 2 years ago

If you'd like to create new images, please do so and PR. Please just do one PR for the entire fix, thanks!

flegaspi700 commented 2 years ago

Done. I've created a PR.

flegaspi700 commented 2 years ago

Closing this issue. PR has been created and merged.