search

microsoft / DbgShell

A PowerShell front-end for the Windows debugger engine.
MIT License
675 stars 89 forks source link

Allow 'bp uint64' #99

Open ReneNyffenegger opened 3 years ago

ReneNyffenegger commented 3 years ago

Reduce the number of parameter-sets in Set-DbgBreakpoint to remove ambuigity when trying to resolve Set-DbgBreakpoint such as Set-DbgBreakpoint $exentry

ReneNyffenegger commented 3 years ago

Dan, I created this pull request because I need to be able to break on an exe's entry point:

bp $exentry

With this pull request, I seem to be able to do that now. Unfortunately, I am not sure if it breaks other use cases of the bp command. In particular, there is no differentiation anymore between choosing between -Command and -DbgEngCommand as I didn't find a way to allow for UInt64 and all parameter sets.

jazzdelightsme commented 3 years ago

Sorry it has taken me so long to get to this. Thanks for the report! As you note, your change makes it possible to pass both -Command and -DbgEngCommand, which wouldn't make sense. We could check at runtime... but I'd prefer to have this enforced by the parameter sets (even though param sets are kind of a pain to get right). I have an idea how to fix this... see #100

In reply to: 808753035 [](ancestors = 808753035)