Closed younesbelkada closed 1 week ago
Thanks @younesbelkada, I believe the second linked PR should resolve this.
@loadams, is it really necessary for us to pin numpy to a pre-2.0.0 version?
I wonder if BUFSIZE was a botched import and the right fix for this is something like:
diff --git a/deepspeed/autotuning/scheduler.py b/deepspeed/autotuning/scheduler.py
index 7d2a1c08..35f709ea 100755
--- a/deepspeed/autotuning/scheduler.py
+++ b/deepspeed/autotuning/scheduler.py
@@ -5,7 +5,6 @@
import copy
-from numpy import BUFSIZE
import json
import subprocess
import sys
@@ -18,7 +17,7 @@ import hjson
from tqdm import tqdm
from ..utils import logger
-from .constants import AUTOTUNING, AUTOTUNING_METRIC_PATH
+from .constants import AUTOTUNING, AUTOTUNING_METRIC_PATH, BUFSIZE
from .utils import get_val_by_key, search_error, was_interruptted
"""
thread-0: loop over experiment queue dispatching experiments if they become available
Um, lmk if this makes sense and I can open a PR for it.
Okay @younesbelkada, DeepSpeed master branch should have this resolved here, one we confirm, we can do a new release as well.
Thank you very much for the quick action @loadams !
Okay @younesbelkada, DeepSpeed master branch should have this resolved here, one we confirm, we can do a new release as well.
5680
please release the fix, to unblock users
Describe the bug
Importing deepspeed on a python env with numpy>=2.0.0 fails:
To Reproduce
pip install deepspeed
on a env with python>=3.9 and import deepspeed