search

microsoft / DeepSpeedExamples

Example models using DeepSpeed
Apache License 2.0
6.1k stars 1.04k forks source link

Deepspeed-Domino #929

Closed zhangsmallshark closed 2 weeks ago

zhangsmallshark commented 2 months ago

Hello team, Deepspeed-Domino contains all related files for Domino project.

GuanhuaWang commented 1 month ago

@zhangsmallshark , regarding to fix loss commit da0c63b

Maybe I miss something, but I don't see any real code change regarding to fwd/bwd/step. The only changes in this commit just add timers, comment some printout vals. idk how loss is fixed in this commit

shenzheyu commented 2 weeks ago

@tjruwase Hi Olatunji, we've resolved all the comments. Could you please help us by starting the final review?

tjruwase commented 2 weeks ago

@tjruwase Hi Olatunji, we've resolved all the comments. Could you please help us by starting the final review?

LGTM! Thanks!