search

microsoft / DesktopBridgeToUWP-Samples

This repo contains the samples that demonstrate the usage patterns for the Desktop Conversion extensions.
MIT License
494 stars 271 forks source link

Dkbennett nativepluginsample #39

Open dkbennett opened 7 years ago

dkbennett commented 7 years ago

Adds native plugins sample to the Desktop Bridge samples.

vladimp commented 7 years ago

Thanks for putting it together!

  1. Please format the readme file similar to the other samples, I mean header, a short intro about what it demonstrates then the part that you have about the sample parts and the last how to utilze it.
  2. Consider to change the names from DLLExtension and DLLExtension2 to something like DLLExtensionNative and DLLExtensionManaged..
  3. I failed to build the ExtensionHost packaging project getting tons of errors, I saw this kind of errors with the combination of the NuGet package and the ref to project that you are using, however I don’t see the Nuget in your solution… Can you try the other packaging approach that we publically document here. (with the sepreate win32 folder)
  4. Please make sure the min/max versions in the manifest; 14393 and 15063..

Kudos on the comments in the code!

Thanks, Vlad