search

microsoft / Detours

Detours is a software package for monitoring and instrumenting API calls on Windows. It is distributed in source code form.
MIT License
5.02k stars 981 forks source link

Maintenance: Revert boolean flip #168

Closed rchildre3 closed 3 years ago

rchildre3 commented 3 years ago

Commit 99ac5f91622c7a95e99c85fb9d7141e6c4d16244 ("Maintenance: Clean up some compiler warnings") flipped a boolean check. Revert.

Reported-by: @sonyps5201314

Microsoft Reviewers: Open in CodeFlow
bgianfo commented 3 years ago

Thanks for the fix, and thank you @sonyps5201314 for noticing the regression.

Not sure how I missed that, everything's harder these days...

sonyps5201314 commented 3 years ago

Not sure how I missed that, everything's harder these days...

Don't worry, it'll all be over soon.

ghost commented 3 years ago

Hello @bgianfo!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 5 hours 24 minutes. No worries though, I will be back when the time is right! :wink:

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.