Closed bgianfo closed 3 years ago
Hello @bgianfo!
Because this pull request has the auto-merge
label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.
@msftbot
) and give me an instruction to get started! Learn more here.Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request.
This PR add more tests for the basic functionality and error handling of the Detours Module API.
DetourLoadImageHlp
DetourFindFunction
DetourEnumerateModules
DetourEnumerateExports
DetourEnumerateImports
DetourGetSizeOfPayloads
DetourFindPayload
DetourFindPayloadEx
DetourRestoreAfterWithEx
It also fixes some error handling issues that the tests found in the module API.
DetoursFindFunction
wasn't gracefully handling NULL function name.DetourEnumerateModules
wasn't resetting GLE on success.DetourEnumerateExports
wasn't gracefully handling NULL export callback.DetourEnumerateImports
wasn't gracefully handling NULL arguments.Microsoft Reviewers: Open in CodeFlow