Document pointer lifetime requirement.

[Lectem]

Describe the bug

It is not documented that we must keep the ppPointer argument of a call to DetourAttach/DetourAttachEx until the transaction is finished (that is, DetourTransactionCommit, DetourTransactionCommitEx or DetourTransactionAbort is called. This can easily lead to use after free (for example if you pass a local variable for the address, which can easily happen if you do not actually use it afterward).

I think this can easily be fixed by adding the following text in the wiki documentation of DetourAttach/DetourAttachEx, in the Remarks section:

Note that the variable pointed to by ppPointer must be alive during the whole transaction, that is until DetourTransactionCommit, DetourTransactionCommitEx or DetourTransactionAbort is called.

[bgianfo]

That's a great suggestion, I've made the proposed wording changes to the DetourAttach and DetourAttachEx wiki pages.

See:

• https://github.com/microsoft/Detours/wiki/DetourAttach/_compare/9edbd998ea52403dac64ba35bd0b796103c74f4c...80bfc67da59efa9a0243da650a742218d3338b43

• https://github.com/microsoft/Detours/wiki/DetourAttachEx/_compare/9edbd998ea52403dac64ba35bd0b796103c74f4c...5aeee3bf50acd30213b4182eb1509bc2d8ecc026

Thanks! 👍