microsoft / DevHomeAzureExtension

Dev Home Azure Extension

MIT License

77 stars 16 forks source link

Moving to .NET 8 #121

Closed dhoehna closed 7 months ago

dhoehna commented 7 months ago

Summary of the pull request

Upgrading everything to .NET 8 and handling all the syntax errors that comes with it.

References and relevant issues

80 is in progress, but this needs to go in because DevHome is in .NET 8.

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

[ ] Closes #xxx
[ ] Tests added/passed
[ ] Documentation updated

AgneLukoseviciute commented 7 months ago

As @manodasanW figured out, the use of version-specific RIDs and the associated workaround will no longer be needed once there's a new version of the Dev Home SDK and the extensions upgrade to it. Namely it needs this change here: Blaming devhome/extensionsdk/nuget/Microsoft.Windows.DevHome.SDK.nuspec at c08f7ed23e6e0070a6d5ab24e40c257309f27a75 · microsoft/devhome (github.com) . Could be good to open up an issue as a reminder to clean this up once it's no longer needed.

chenss3 commented 7 months ago

As @manodasanW figured out, the use of version-specific RIDs and the associated workaround will no longer be needed once there's a new version of the Dev Home SDK and the extensions upgrade to it. Namely it needs this change here: Blaming devhome/extensionsdk/nuget/Microsoft.Windows.DevHome.SDK.nuspec at c08f7ed23e6e0070a6d5ab24e40c257309f27a75 · microsoft/devhome (github.com) . Could be good to open up an issue as a reminder to clean this up once it's no longer needed.

I opened up an issue (#81) for the previous PR (#80) that we could potentially reuse.