Add support for signin Urls being valid AzureUris - Githubissues

microsoft / DevHomeAzureExtension

Dev Home Azure Extension

MIT License

78 stars 16 forks source link

Add support for signin Urls being valid AzureUris #7

Closed dkbennett closed 11 months ago

dkbennett commented 11 months ago

Summary of the pull request

Updates the AzureUri parsing to allow Azure Signin Uris to be considered valid Uris.

References and relevant issues

Closes https://github.com/microsoft/DevHomeADOExtension/issues/77

Detailed description of the pull request / Additional comments

Updated AzureUri to allow subdomains for dev.azure.com.
Updated AzureUri to allow {organization}.vsspss.visualstudio.com/ style Uris.
Added many test cases for these new Uris.
Updated validation to ensure connection and Uri match where they should match.

Validation steps performed

Verified new tests run successfully and that all new Uris added to the validation tests pass.

PR checklist

[x] Closes #xxx
[x] Tests added/passed
[x] Documentation updated

dkbennett commented 11 months ago

@dhoehna Please verify the Uris added to the valid test list correctly capture the known expected Uri formats for signin Uris.

vineeththomasalex commented 11 months ago

Nice!