search

microsoft / DevSkim

DevSkim is a set of IDE plugins, language analyzers, and rules that provide security "linting" capabilities.
MIT License
910 stars 116 forks source link

Outdated Actions and runners #584

Closed maj113 closed 1 year ago

maj113 commented 1 year ago

changelog.yml:

Update runner to ubuntu-latest, the readme.md of changelog-check-action was written 2 years ago when 22.04 wasn't a runner image yet, the code it runs seems simple enough so the change most likely wouldn't break anything

Also note that 18.04 was deprecated a year ago (Aug. 2022 - Apr. 2023) so 20.04 may follow that timeline

publish-api-docs.yml:

actions/checkout@v3 -> v4 no major changes actions/setup-dotnet@v1 -> v3 seems to have some syntax changes, v1 seems unmaintained, last commit in Feb. 2022 also add some caching support we may be able to utilize

actions/upload-pages-artifact@v1 -> v2 may need manual chmod(?)

gfs commented 1 year ago

Thanks @maj113. If you want to submit a PR for these I can review. Otherwise I'll try to address these later this week.

maj113 commented 1 year ago

Thanks @maj113. If you want to submit a PR for these I can review. Otherwise I'll try to address these later this week.

Sure, I'll PR either today or tomorrow, didn't know if it was necessary/accepted so I created an issue instead