microsoft / DirectXMesh

DirectXMesh geometry processing library
https://walbourn.github.io/directxmesh/
MIT License
787 stars 151 forks source link

Remove use of DWORD in public interface #44

Closed walbourn closed 4 years ago

walbourn commented 4 years ago

I changed most of the functions to take C++ Standard Types, but never fixed up DWORD out of concern for changing link signatures.

I should really change it to something standard.

walbourn commented 4 years ago

Fixed in this commit

walbourn commented 4 years ago

Direct3D already uses a DEFINE_ENUM_FLAG_OPERATORS macro (in winnt.h) to make an enum work as you'd expect for bitmask flags based on recommendations in the C+ standard under 17.5.2.1.3 Bitmask types so I'll go with that.

See also StackOverflow for discussion of the best Modern C++ practice here.