microsoft / DirectXShaderCompiler

This repo hosts the source for the DirectX Shader Compiler which is based on LLVM/Clang.
Other
3.11k stars 698 forks source link

[SPIR-V][SM6.7] Add support for RWTexture2DMS in the SPIR-V backend #5244

Open sharayua opened 1 year ago

sharayua commented 1 year ago

I am trying to implement the RWTexture2DMS feature from SM 6.7 using DXC packages from the Agility SDK. This is a dummy shader with minimal code. Surprisingly, the shader compiles fine for DXIL, https://godbolt.org/z/z8qvbMEjd but fails with SPIR-V, https://godbolt.org/z/59nPrsbdo

Would this be fixed in the coming some weeks?

~SA

s-perron commented 1 year ago

Would this be fixed in the coming some weeks?

Don't expect a fix any time soon. When I looked at the spir-v generated by DXC, I noticed is wrong a lot of ways. We do not have many people working on DXC spir-v right now.

This issues was discussed in the Vulkan docs, and can give an idea of how to implement it correctly:

https://github.com/KhronosGroup/Vulkan-Docs/issues/1015

devshgraphicsprogramming commented 6 months ago

Maybe this is another place to roll out Proposal 0011 user space code?

s-perron commented 6 months ago

Maybe this is another place to roll out Proposal 0011 user space code?

We still need to implement this, even if a Vulkan only implementation can get by with inline spir-v. We want people to be able to write code that will work for both DXIL and SPIR-V.