Assertion `MaybeODRUseExprs.empty() && "Leftover expressions for odr-use checking"` in heavily templated code

[devshgraphicsprogramming]

Description

We do some very simple metaprogramming consteval math for attributes

Steps to Reproduce

These sorts of bugs are a problem to reproduce on your official Godbolt as you don't have assertions/exception enabled builds: https://godbolt.org/z/EnnPxqbfa

We have our own instance with a Debug build, but outside of a debugger you can't see the assertion being raised our short links don't work yet

Actual Behavior

One assertion per compilation:

Error: assert(MaybeODRUseExprs.empty() && "Leftover expressions for odr-use checking")
File:
D:\work\Nabla\3rdparty\dxc\dxc\tools\clang\lib\Sema\SemaDecl.cpp(11119)
Func:    clang::Sema::ActOnFinishFunctionBody

Environment

• DXC version: latest trunk as of Nov 04
• Host Operating System: godbolt

[devshgraphicsprogramming]

If you remove the SPIR-V specific [[]] attributes it might still assert without -spirv option

https://godbolt.org/z/Kqqx9nvbq

[llvm-beanz]

There is nothing here which indicates that this actually is causing incorrect code generation, so the severity here seems extremely low. There are lots of asserts that fire in DXC for a variety of reasons, not all of them indicate actual failures, some of them are just incorrect asserts.

[devshgraphicsprogramming]

There is nothing here which indicates that this actually is causing incorrect code generation, so the severity here seems extremely low. There are lots of asserts that fire in DXC for a variety of reasons, not all of them indicate actual failures, some of them are just incorrect asserts.

its somewhat annoying that my examples don't work/crash outside of a debugger.

How can I skip the asserts?

[devshgraphicsprogramming]

I need a compile flag that can turn these asserts into prints to stdout or just skip them.

I started building more code on top of this and now I need to manually resume with the debugger 8 times for a single shader

[devshgraphicsprogramming]

Actually it seems that the assert is triggered by [[numthreads(static const member variable here,1,1)]]

https://tinyurl.com/2p2utrw5

there isn't even template or typedef/using involved

[Fletterio]

I'm having a similar issue with a similar pattern using COnstevalParameters, hitting an "unreachable" assert on SemaHLSL.cpp