[x] Does this PR have a descriptive title that could go in our release notes?
[ ] Does this PR add any new dependencies?
[x] Does this PR modify any existing APIs?
[x] Is the change to the API backwards compatible?
[x] Should this result in any changes to our documentation, either updating existing docs or adding new ones?
What does this implement/fix? Briefly explain your changes.
Allows for the building of and searching of a filtered memory index, by providing a simple list[list[Hashable]] mapping at build time, and enabling it with a flag on load.
Any other comments?
I am not totally confident I know the full set of expectations, behaviors, and bounding edge cases for test in this particular scenario. @harsha-simhadri if you could explain precisely what edge cases I should properly test for other than the basics in this PR, I would be deeply appreciative!
daxpryce
commented
10 months ago
What does this implement/fix? Briefly explain your changes.
Allows for the building of and searching of a filtered memory index, by providing a simple list[list[Hashable]] mapping at build time, and enabling it with a flag on load.
Any other comments?
I am not totally confident I know the full set of expectations, behaviors, and bounding edge cases for test in this particular scenario. @harsha-simhadri if you could explain precisely what edge cases I should properly test for other than the basics in this PR, I would be deeply appreciative!