replace callback with Wait() method

microsoft / DiskANN

Graph-structured Indices for Scalable, Fast, Fresh and Filtered Approximate Nearest Neighbor Search

Other

1.02k stars 208 forks source link

replace callback with Wait() method #526

Closed hliu18 closed 5 months ago

hliu18 commented 5 months ago

replace callback driven wait logic in getNextCompletedRequest with new interface method Wait() on AlignedFileReader directly. details moved into Wait() implementation and becomes transparent to the caller. The change is needed to accommodate lower IO layer implementation that does not support callback.

change affects only code inside USE_BING_INFRA.

hliu18 commented 5 months ago

@harsha-simhadri can you help merge this PR? thanks.