Handle fc layer output shape when C is single dimension

microsoft / ELL

Embedded Learning Library

https://microsoft.github.io/ELL

Other

2.29k stars 294 forks source link

Handle fc layer output shape when C is single dimension #219

Open dashesy opened 5 years ago

dashesy commented 5 years ago

Also warn about non-symmetric padding and strides, until support is added.

lovettchris commented 5 years ago

Thanks, looks like another good pull request, I added some comments.

dashesy commented 5 years ago

I cannot see the comments yet, will look as soon as you have finalized the CR. Thanks

dashesy commented 5 years ago

I will submit another PR

lovettchris commented 5 years ago

Ok, thanks. I suspect the right fix might be to add some reinterpretlayout nodes on whatever nodes is downstream of the fc layer that needs something that is not 1d.