search

microsoft / ELL

Embedded Learning Library
https://microsoft.github.io/ELL
Other
2.29k stars 295 forks source link

F524 '...'.format(...) is missing argument(s) for placeholder(s): 1 #249

Closed arachid1 closed 3 years ago

arachid1 commented 4 years ago

Hello,

I am attempting to build ELL but get an error at 84% when running the make file.

The output of 'cmake ..' (completes successfully):

-- The C compiler identification is AppleClang 11.0.0.11000033
-- The CXX compiler identification is AppleClang 11.0.0.11000033
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc - works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ - works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- ELL version 3.0.3
CMake Warning (dev) at CMakeLists.txt:46 (set):
  implicitly converting 'DOCUMENTATION' to 'STRING' type.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Configuring tests to use TEST_MODELS_REPO at: https://github.com/Microsoft/ell-test-models
CMake Warning (dev) at CMakeLists.txt:48 (set):
  implicitly converting 'DOCUMENTATION' to 'STRING' type.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Looking for python 3.7: PYTHONINTERP_FOUND=TRUE, PYTHONLIBS_FOUND=TRUE
-- PYTHON_EXECUTABLE=/usr/local/bin/python3.7
-- PYTHON_VERSION_STRING=3.7.4
-- PYTHON_VERSION_MAJOR=3
-- PYTHON_LIBRARIES=/usr/local/Frameworks/Python.framework/Versions/3.7/lib/libpython3.7m.dylib
-- PYTHON_INCLUDE_PATH=/usr/local/Frameworks/Python.framework/Versions/3.7/include/python3.7m
-- PYTHON_INCLUDE_DIRS=/usr/local/Frameworks/Python.framework/Versions/3.7/include/python3.7m
-- PYTHON_DEBUG_LIBRARIES=
-- PYTHONLIBS_VERSION_STRING=3.7.4
-- using program '/opt/anaconda3/envs/KWS/bin/flake8' with /Users/alirachidi/Documents/folder/KWS/ELL/.flake8
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Using BLAS include path: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/
System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/Headers
-- Using BLAS library: /usr/lib/libcblas.dylib
-- Using BLAS DLLs:
-- Found LLVM 8.0.1
-- Using LLVMConfig.cmake in: /usr/local/Cellar/llvm@8/8.0.1_3/lib/cmake/llvm
-- Found SWIG: /usr/local/bin/swig (found suitable version "4.0.1", minimum required is "4.0.0")
-- Found SWIG_EXECUTABLE=/usr/local/bin/swig
-- Skipping pitest because one of RPI_CLUSTER, RPI_PASSWORD, RPI_KEY, TEST_MODELS_REPO is missing
-- Creating wrappers for python
CMake Warning (dev) at /usr/local/Cellar/cmake/3.17.3/share/cmake/Modules/UseSWIG.cmake:607 (message):
  Policy CMP0078 is not set: UseSWIG generates standard target names.  Run
  "cmake --help-policy CMP0078" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

Call Stack (most recent call first):
  CMake/CommonInterfaces.cmake:151 (swig_add_library)
  CMake/CommonInterfaces.cmake:195 (generate_interface_module)
  interfaces/python/CMakeLists.txt:21 (generate_interface)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at /usr/local/Cellar/cmake/3.17.3/share/cmake/Modules/UseSWIG.cmake:460 (message):
  Policy CMP0086 is not set: UseSWIG honors SWIG_MODULE_NAME via -module
  flag.  Run "cmake --help-policy CMP0086" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.17.3/share/cmake/Modules/UseSWIG.cmake:702 (SWIG_ADD_SOURCE_TO_MODULE)
  CMake/CommonInterfaces.cmake:151 (swig_add_library)
  CMake/CommonInterfaces.cmake:195 (generate_interface_module)
  interfaces/python/CMakeLists.txt:21 (generate_interface)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Creating wrappers for javascript
CMake Warning (dev) at /usr/local/Cellar/cmake/3.17.3/share/cmake/Modules/UseSWIG.cmake:460 (message):
  Policy CMP0086 is not set: UseSWIG honors SWIG_MODULE_NAME via -module
  flag.  Run "cmake --help-policy CMP0086" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

Call Stack (most recent call first):
  CMake/CommonInterfaces.cmake:137 (SWIG_ADD_SOURCE_TO_MODULE)
  CMake/CommonInterfaces.cmake:195 (generate_interface_module)
  interfaces/javascript/CMakeLists.txt:7 (generate_interface)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found npm at /usr/local/bin/npm
-- Creating wrappers for xml
CMake Warning (dev) at /usr/local/Cellar/cmake/3.17.3/share/cmake/Modules/UseSWIG.cmake:460 (message):
  Policy CMP0086 is not set: UseSWIG honors SWIG_MODULE_NAME via -module
  flag.  Run "cmake --help-policy CMP0086" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

Call Stack (most recent call first):
  CMake/CommonInterfaces.cmake:137 (SWIG_ADD_SOURCE_TO_MODULE)
  CMake/CommonInterfaces.cmake:195 (generate_interface_module)
  interfaces/xml/CMakeLists.txt:6 (generate_interface)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Writing: /Users/alirachidi/Documents/folder/KWS/ELL/build/config.json
CMake Warning at CMakeLists.txt:221 (message):
  Doxygen processor not found

-- Configuring done
-- Generating done
-- Build files have been written to: /Users/alirachidi/Documents/folder/KWS/ELL/build

Output of 'make':

[ 84%] Linking CXX executable value_test
[ 84%] Built target value_test
Scanning dependencies of target importers_common
Running flake8 on /Users/alirachidi/Documents/folder/KWS/ELL/tools/importers/common ...
[ 84%] Built target importers_common
Scanning dependencies of target pythonlibs
Running flake8 on /Users/alirachidi/Documents/folder/KWS/ELL/tools/utilities/pythonlibs ...
./picluster.py:156:33: F524 '...'.format(...) is missing argument(s) for placeholder(s): 1
./audio/training/dataset.py:98:45: E741 ambiguous variable name 'l'
make[2]: *** [pythonlibs] Error 1
make[1]: *** [tools/utilities/pythonlibs/CMakeFiles/pythonlibs.dir/all] Error 2
make: *** [all] Error 2

In addition, I get a LOT of warnings (i.e., 2-5 every other %) when running the make command, often related to explicitly marked deletions of constructors and operators in files like Port.h or IREmitter.h. Here are a few examples:

ELL/libraries/emitters/include/IREmitter.h:56:20: warning: explicitly defaulted
      move assignment operator is implicitly deleted [-Wdefaulted-function-deleted]
        IREmitter& operator=(IREmitter&&) = default;
ELL/libraries/model/include/Port.h:42:9: note: 'Port' has been explicitly
      marked deleted here
        Port(Port&& other) = delete;

I'm worried they might cause this issue or other ones.

I'm also adding the following in case it this helps:

cmake version 3.17.3

gcc-8 --version gives bash: gcc-8: command not found

Thank you in advance!

arachid1 commented 4 years ago

On line 156 of picluster.py, I added the comment "# noqa: F524" to ignore the error, which fixed the issue. However, because it's an error saying the missing argument is the IP address, I'm worried this will lead to further problem.

Line 156:

raise Exception("Lock failed on machine {}, lock key mismatch {}".format(ip))  # noqa: F524
lovettchris commented 3 years ago

This is fixed now, thanks.