search

microsoft / EmbeddedSocial-Android-SDK

SDK for interacting with the Microsoft Embedded Social service from inside your Android app
MIT License
9 stars 14 forks source link

Stefan/rename idproviders #77

Closed ssaroiu closed 6 years ago

ssaroiu commented 6 years ago

This PR only does some renaming. It should not introduce any code changes.

MSA, Facebook, Google, and Twitter are third-party id providers in Embedded Social (and not social networks). I changed the name of the relevant types and variables to reflect this.

Note: I haven't tested this PR on my phone. I'm planning to do that tomorrow.

acrown-msft commented 6 years ago

Have you had a chance to test this on a device?

ssaroiu commented 6 years ago

I did test that I can login with all three id providers: MSA, G, and FB. I used the Nexus 6P phone to test. No issues.