microsoft / FASTER

Fast persistent recoverable log and key-value store + cache, in C# and C++.
https://aka.ms/FASTER
MIT License
6.29k stars 563 forks source link

apply [SkipLocalsInit] #906

Open mgravell opened 5 months ago

mgravell commented 5 months ago

context: https://github.com/microsoft/FASTER/issues/904

it looks like the code doesn't actually use stackalloc etc (which is surprising), which makes this simpler; there are quite a few [FieldOffset], which can in theory leave uninitialized holes in types - but... I don't think the code does anything wrong there. Eyeballs encouraged!