search

microsoft / FFmpegInterop

This is a code sample to make it easier to use FFmpeg in Windows applications.
Apache License 2.0
1.28k stars 310 forks source link

Is there any reason why h.264 encoding isn't enabled by default in the configure script? #124

Open atraczyk opened 7 years ago

atraczyk commented 7 years ago

As is, h.264 decoding works by default, but encoding requires the x264 library. Considering h.264's performance in real-time communications, is there a plan to integrate this into the FFmpegInterop project and its configuration script?

If there's no known major issues, and it's just that the work hasn't been done yet, I'll take a stab at it.

khouzam commented 7 years ago

Hi @atraczyk

There isn't a particular reason why the x264 library is not included, we're mostly following the defaults that FFmpeg includes. I think that there might be a licensing issue and that might be why it's not included by default, but we can always give the option to include the library for those interested as long as the right licensing is followed.

atraczyk commented 7 years ago

OK thanks @khouzam. I've got it working, and am using it for RTC. There are a few references outside the UWP API, but I should be able to resolve those quickly. Thanks again.