microsoft / FFmpegInterop

This is a code sample to make it easier to use FFmpeg in Windows applications.
Apache License 2.0
1.28k stars 309 forks source link

VS2017? #136

Open hansmbakker opened 7 years ago

hansmbakker commented 7 years ago

It seems that BuildFFmpeg.bat wants to use VS2015. Could you please update it to support VS2017?

khouzam commented 7 years ago

Yes, the way to detect the tools has changed with VS2017. We are looking at updating the scripts to support VS2017.

ryanwinter commented 7 years ago

Here's the updated Buildffmpeg.bat I used for vs 2017 BuildFFmpeg.zip

farazp commented 7 years ago

Hi, this isn't for VS2017

khouzam commented 7 years ago

The code works fine for VS 2017, we just haven't had a chance to fully update the build scripts to support VS 2017. I've got most the necessary changes but need to validate with different install combinations.

dantler commented 7 years ago

In the interim, you could try this. Worked for me.

farazp commented 7 years ago

I try both, but I got error "VS140COMNTOOLS environment variable is not found. Check your Visual Studio 2015 installation" how to fix this?

khouzam commented 7 years ago

This is because the scripts haven't been updated for VS2017.

I've been investigating a new package manager that Microsoft is developing and it does make things a lot easier to get started and works great for both VS2015 and VS2017. That's partly why it's taken me longer to get the scripts updated to VS2017.

The project is vcpkg and it already supports a bunch of different projects with both VS2015 and VS2017. They have already added support for FFmpeg and I've issued a pull request to add the UWP version of FFmpeg.

To try it out is quite simple:

Now comes the even more interesting part, the integration with VS.

You can see how this has simplified the projects with the vcpkg branch that I just updated.

I would love to hear people's thoughts on this approach, personally I found this to be much easier to setup.

touseefbsb commented 7 years ago

I just wanted to ask why cant we have a nugget package for this repo? So that it gets simpler to integrate it in any uwp project on any machine instead of building it and then integrating it on a machine whenever we want to use it?

touseefbsb commented 7 years ago

the reason I asked thisis because on some machines it builds successfully but on some machines it gives many errors, so if there was a straight forward package that would simplify things

ahmar20 commented 7 years ago

How do you reference these integrated packages in VS 2017 for C#?

lukasf commented 6 years ago

@touseefbsb I think there are legal reasons why no compiled builds of ffmpeg are distributed. Some of the codecs might be covered by patents. The authors of ffmpeg "only show you how this could be decoded" but they do not offer any running decoders/encoders. If you compile yourself, then you are the one who acutally built the decoder assembly...