search

microsoft / FFmpegInterop

This is a code sample to make it easier to use FFmpeg in Windows applications.
Apache License 2.0
1.29k stars 310 forks source link

Sample Presentaion Timestamp #195

Closed khouzam closed 3 months ago

khouzam commented 6 years ago

Fix to use the start_time of the stream for the startOffset instead of the first packet timestamp. From issue #172

brabebhin commented 6 years ago

Looks OK so far, I will give it some more tests tomorrow.

brabebhin commented 6 years ago

Good to merge.

reego-fr commented 6 years ago

It is good to use ffmpeg start_time value to fix the issue reported by @mcosmin222 but there are still minor fixes to correctly play and be able to seek to correct timestamps on MPEG-PS VOB files and MPEG-TS stream dumps. Should I create a new pull request with these changes or push changes here ?

brabebhin commented 6 years ago

Yes, please do so, since you have better knowledge about it. Thanks

reego-fr commented 6 years ago

I merged the older fix, I'm not sure why the username is wrong but the code should be good.

brabebhin commented 6 years ago

You fix is similar to what i had, but didnt include all the cases. It works. Good to merge.

reego-fr commented 6 years ago

I changed av_seek_frame to use the stream's start_time which makes more sense and hopefully may solve issues occuring on playback start with some files such as one found here https://github.com/Microsoft/FFmpegInterop/issues/201

brabebhin commented 6 years ago

@reego-fr , is this working OK for you now? My use case is fixed, so perhaps @khouzam can merge it is everything is OK on your end.