microsoft / FFmpegInterop

This is a code sample to make it easier to use FFmpeg in Windows applications.
Apache License 2.0
1.3k stars 310 forks source link

Working on a fork to integrate all changes #219

Open lukasf opened 6 years ago

lukasf commented 6 years ago

I got a bit bored lately. There is so much work done here lately, so many fixes and improvements, but it is not possible to test it all together because it is all scatterd throughout various branches, nothing is merged. To solve #217, a bigger refactoring is neccessary (at least in my opinion), but it's not possible (or advisable) to do this with so many open big PRs. And I did not want to wait. So I just went ahead and started working on my own fork (https://github.com/lukasf/FFmpegInterop). I done the refactoring there, I improved various things along the way. I merged (or re-implemented) almost all open PRs. I have done some initial testing, things look good so far. Some of the files that did not work before now work fine.

These are some of the things I improved, in addition to the PRs:

Maybe it is a good idea to work on this fork, instead of making even more branches? We can test all the changes there. When we have a good and stable state, and when @khouzam is back from hibernation, we could merge everything back into the official repo.

The next big thing I would like to do is multi audio streams (which again requires bigger rework of the whole thing).

I would invite anyone who likes the idea, to join my fork and test with their files. Who is interested? @mcosmin222 @reego-fr ?

brabebhin commented 6 years ago

I am all for it. Lately i have been working on getting audio effects support into the stream source, I will bring this feature into the fork, but I will need to refactor it because it was meant to work with the Microsoft build.

lukasf commented 6 years ago

Cool, I sent an invite. Feel free to create branches directly on the fork.