Add ruff sort to pre-commit and sort imports in the library

microsoft / FLAML

A fast library for AutoML and tuning. Join our Discord: https://discord.gg/Cppx2vSPVP.

https://microsoft.github.io/FLAML/

MIT License

3.76k stars 495 forks source link

Add ruff sort to pre-commit and sort imports in the library #1259

Closed glevv closed 3 months ago

glevv commented 7 months ago

Why are these changes needed?

To maintain clean and lean imports

Related issue number

Closes #1252

Checks

[x] I've included any doc changes needed for https://microsoft.github.io/FLAML/. See https://microsoft.github.io/FLAML/docs/Contribute#documentation to build and test documentation locally.
[x] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[x] I've made sure all auto checks have passed.

glevv commented 7 months ago

I almost sure that some tests will start to fail, so there still some work to be done

glevv commented 6 months ago

Should OpenAI tests also run?

thinkall commented 6 months ago

Should OpenAI tests also run?

This will be triggered later when approved.

glevv commented 5 months ago

I'm not sure why OpenAI checks are failing.

thinkall commented 5 months ago

I'm not sure why OpenAI checks are failing.

@sonichi could you take a look at this? Thanks.

glevv commented 4 months ago

I don't think it is possible to automerge without all the checks being green

Borda commented 4 months ago

I don't think it is possible to automerge without all the checks being green

That is right, but ~it seems that even all checks on mater are not green~ it seems some tests are flaky so this will need to wait until main branch is healthy =)

Borda commented 3 months ago

@sonichi @thinkall @jackgerrits how about adding this bot which would help with all this manual linitng?