microsoft / FLAML

A fast library for AutoML and tuning. Join our Discord: https://discord.gg/Cppx2vSPVP.
https://microsoft.github.io/FLAML/
MIT License
3.75k stars 495 forks source link

docs: fix link to reference #1263

Closed Borda closed 4 months ago

Borda commented 6 months ago

Why are these changes needed?

it does not render as a link in the docs, see: https://microsoft.github.io/FLAML/docs/reference/default/greedy

Related issue number

Checks

Borda commented 6 months ago

@sonichi, I do not think that my docs fix would break the code as the tests are failing now; it is coming from the master or some flaky cases?

sonichi commented 6 months ago

This looks an issue related to spark. @thinkall for awareness.

Borda commented 5 months ago

seems that very same test are failing also on main branch so would be worse to check it to unblock all pending PRs

thinkall commented 4 months ago

This looks an issue related to spark. @thinkall for awareness.

I've raised a PR #1274 to fix the issues.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b645da3) 71.72% compared to head (0d2039c) 71.59%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1263 +/- ## ========================================== - Coverage 71.72% 71.59% -0.13% ========================================== Files 83 83 Lines 11249 11249 Branches 2360 2360 ========================================== - Hits 8068 8054 -14 - Misses 2726 2738 +12 - Partials 455 457 +2 ``` | [Flag](https://app.codecov.io/gh/microsoft/FLAML/pull/1263/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/microsoft/FLAML/pull/1263/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `71.47% <ø> (-0.13%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Borda commented 4 months ago

@sonichi kindly reminder for review... :chipmunk: