search

microsoft / FLAML

A fast library for AutoML and tuning. Join our Discord: https://discord.gg/Cppx2vSPVP.
https://microsoft.github.io/FLAML/
MIT License
3.75k stars 495 forks source link

Typo or misnaming in automl/timeseries/ts_model.py #1279

Open enkiluv opened 4 months ago

enkiluv commented 4 months ago

In version 2.x.x: (especially 2.1.1)

Lines 613 and 616: if ( self.params["seasonal"] == "mul" and (train_df.y == 0).sum() > 0 ): # cannot have multiplicative seasonality in this case self.params["seasonal"] = "add" if self.params["trend"] == "mul" and (train_df.y == 0).sum() > 0: self.params["trend"] = "add"

train_df.y == 0 should be train_df[target_col] == 0 . Isn't it? (two places)

Programmer-RD-AI commented 1 month ago

Hi, I have created a PR #1312 feel free to check it :) Best regards