Other di containers - Githubissues

microsoft / FeatureManagement-Dotnet

Microsoft.FeatureManagement provides standardized APIs for enabling feature flags within applications. Utilize this library to secure a consistent experience when developing applications that use patterns such as beta access, rollout, dark deployments, and more.

MIT License

1.06k stars 115 forks source link

Other di containers #126

Closed da1rren closed 1 year ago

da1rren commented 3 years ago

Hey Guys,

We're attempting to use this in a .net framework application that uses autofac. While attempting to register the various dependencies:

ConfigurationFeatureDefinitionProvider
FeatureManager
EmptySessionManager
FeatureManagerSnapshot

I've discovered that they are all sealed, is there any guidance or is it even possible to use this without resorting to reflection hacks?

jeffcollaboro commented 3 years ago

... or any other number of containers, Simple Injector etc, These classes are the public interface into feature flags they shouldn't be internal, we need to instantiate them to use this.

danielmackay commented 1 year ago

We're having this problem also. It would be great to see some guidance of how to use the FeatureManager with other IoC containers.

zhiyuanliang-ms commented 1 year ago

Update: The PR #302 of exposing FeatureManager to public has been merged into main branch. Now the FeatureManagement should be compatible with other DI framework.

zhiyuanliang-ms commented 1 year ago

Fixed in release 3.1.0

zhiyuanliang-ms commented 1 year ago

I created a repo to demonstrate how to use Microsoft.FeatureManagement in third-party Di containers: https://github.com/zhiyuanliang-ms/FeatureManagement-Dotnet-DependencyInjection :)