Fix solution issues - Githubissues

microsoft / FeatureManagement-Dotnet

Microsoft.FeatureManagement provides standardized APIs for enabling feature flags within applications. Utilize this library to secure a consistent experience when developing applications that use patterns such as beta access, rollout, dark deployments, and more.

MIT License

1.06k stars 115 forks source link

Fix solution issues #305

Closed jimmyca15 closed 12 months ago

jimmyca15 commented 1 year ago

missing project inclusion in solution file
Project declared nullable support but wasn't written with it in mind
pack.ps1 script didn't reference newest project.

zhiyuanliang-ms commented 1 year ago

Should we remove the nullable declaration in RazorPages example project?

https://github.com/jimmyca15/FeatureManagement-Dotnet/blob/user/jimmyca/fixSolution/examples/RazorPages/Pages/Error.cshtml.cs#L11

jimmyca15 commented 1 year ago

@zhiyuanliang-ms any further concerns on this PR?

zhiyuanliang-ms commented 1 year ago

@jimmyca15 I have no further concerns about this PR.