search

microsoft / FeatureManagement-Dotnet

Microsoft.FeatureManagement provides standardized APIs for enabling feature flags within applications. Utilize this library to secure a consistent experience when developing applications that use patterns such as beta access, rollout, dark deployments, and more.
MIT License
1.06k stars 115 forks source link

Remove redundant if check for logger #400

Closed zhiyuanliang-ms closed 8 months ago

zhiyuanliang-ms commented 8 months ago

Maintain a consistent code style. https://github.com/microsoft/FeatureManagement-Dotnet/blob/main/src/Microsoft.FeatureManagement/FeatureManager.cs#L219 https://github.com/microsoft/FeatureManagement-Dotnet/blob/main/src/Microsoft.FeatureManagement/ConfigurationFeatureDefinitionProvider.cs#L367

Eskibear commented 8 months ago

Just some thoughts: Is it possible to setup linting check in CI? That can be helpful.