search

microsoft / FeatureManagement-Dotnet

Microsoft.FeatureManagement provides standardized APIs for enabling feature flags within applications. Utilize this library to secure a consistent experience when developing applications that use patterns such as beta access, rollout, dark deployments, and more.
MIT License
1.03k stars 111 forks source link

Adjusts namespace to simply ~.Telemetry #417

Closed rossgrambo closed 5 months ago

rossgrambo commented 5 months ago

Why this PR?

Addresses https://github.com/microsoft/FeatureManagement-Dotnet/issues/392

Visible Changes

Developers using any of our offered telemetry publishers will use using Microsoft.FeatureManagement.Telemetry; and developers using any of our offered telemetry initializers will use using Microsoft.FeatureManagement.Telemetry.AspNetCore;.

We will no longer have service specific namespaces like using ~.ApplicationInsights.~; except for extension methods.

zhiyuanliang-ms commented 5 months ago

Should we also update the .csproj and .sln file?

zhiyuanliang-ms commented 5 months ago

Is there any reason why we didn't simplify Microsoft.FeatureManagement.Telemetry.ApplicationInsights.AspNetCore in this PR?

rossgrambo commented 5 months ago

Is there any reason why we didn't simplify Microsoft.FeatureManagement.Telemetry.ApplicationInsights.AspNetCore in this PR?

I had the same question. In the issue I asked and Jimmy had a valid point against it. https://github.com/microsoft/FeatureManagement-Dotnet/issues/392#issuecomment-2040274928

rossgrambo commented 5 months ago

Should we also update the .csproj and .sln file?

We only updated the namespace and not the package. So customers still install the Microsoft.FeatureManagement.Telemetry.ApplicationInsights package- but they only need using Microsoft.FeatureManagement.Telemetry;.

Because the package name didn't change I don't think those need to be updated- but let me know if there's somewhere I'm missing.