search

microsoft / FeatureManagement-Dotnet

Microsoft.FeatureManagement provides standardized APIs for enabling feature flags within applications. Utilize this library to secure a consistent experience when developing applications that use patterns such as beta access, rollout, dark deployments, and more.
MIT License
1.05k stars 115 forks source link

Remove variant & telemetry support for .NET Feature Management schema #421

Closed zhiyuanliang-ms closed 7 months ago

zhiyuanliang-ms commented 7 months ago

Why this PR?

In previous versions, the primary schema for the feature management library was the .NET feature management schema. Starting from v4.0.0, new features including variants and telemetry will not be supported for the .NET feature management schema. #408

This PR follows up #414

Visible Changes

Variant and telemetry are no longer supported for the .NET Feature Management schema.

The removed fields of feature flag declaration include Status, Variants, Allocation, Telemetry

The test suite is also re-organized.

amerjusupovic commented 7 months ago

Is there a reason to still pass in values for status, allocation, variants, telemetry to the FeatureDefinition constructor at the end of the ParseDotnet method? It looks like they should be removed, as well as the temporary variables like Allocation allocation = null at the beginning.

zhiyuanliang-ms commented 7 months ago

Is there a reason to still pass in values for status, allocation, variants, telemetry to the FeatureDefinition constructor at the end of the ParseDotnet method? It looks like they should be removed, as well as the temporary variables like Allocation allocation = null at the beginning.

My bad. I forget to remove them.

zhiyuanliang-ms commented 7 months ago

@jimmyca15 Should we update appsettings.json for all example projects to use Microsoft schema? Currently, I only updated the EvaluationDataToApplicationInsights example.

jimmyca15 commented 7 months ago

@jimmyca15 Should we update appsettings.json for all example projects to use Microsoft schema? Currently, I only updated the EvaluationDataToApplicationInsights example.

yes