Closed zhiyuanliang-ms closed 4 months ago
Is there a reason to still pass in values for status, allocation, variants, telemetry to the FeatureDefinition constructor at the end of the ParseDotnet method? It looks like they should be removed, as well as the temporary variables like Allocation allocation = null
at the beginning.
Is there a reason to still pass in values for status, allocation, variants, telemetry to the FeatureDefinition constructor at the end of the ParseDotnet method? It looks like they should be removed, as well as the temporary variables like Allocation allocation = null at the beginning.
My bad. I forget to remove them.
@jimmyca15 Should we update appsettings.json for all example projects to use Microsoft schema? Currently, I only updated the EvaluationDataToApplicationInsights example.
@jimmyca15 Should we update appsettings.json for all example projects to use Microsoft schema? Currently, I only updated the EvaluationDataToApplicationInsights example.
yes
Why this PR?
In previous versions, the primary schema for the feature management library was the .NET feature management schema. Starting from v4.0.0, new features including variants and telemetry will not be supported for the .NET feature management schema. #408
This PR follows up #414
Visible Changes
Variant and telemetry are no longer supported for the .NET Feature Management schema.
The removed fields of feature flag declaration include
Status
,Variants
,Allocation
,Telemetry
The test suite is also re-organized.