search

microsoft / FeatureManagement-Dotnet

Microsoft.FeatureManagement provides standardized APIs for enabling feature flags within applications. Utilize this library to secure a consistent experience when developing applications that use patterns such as beta access, rollout, dark deployments, and more.
MIT License
1.05k stars 115 forks source link

Consider moving `TargetingHttpContextMiddleware` to the App Insights package #424

Closed rossgrambo closed 3 months ago

rossgrambo commented 7 months ago

We could move TargetingHttpContextMiddleware to the same package as TargetingTelemetryInitializer. The TargetingHttpContextMiddleware is not intended to be used without the TargetingTelemetryInitializer.

jimmyca15 commented 7 months ago

If we do that, I'd like to see the library expose an

AddXyz

and

UseXyz pattern.

jimmyca15 commented 7 months ago

I imagine that taking this change would result in changes in https://github.com/microsoft/FeatureManagement-Dotnet/pull/416

rossgrambo commented 3 months ago

The middleware has been reworked to use Activity, which is no longer specific to App Insights. Leaving in the AspNetCore package now makes sense.