Closed wenkepaul closed 2 months ago
@microsoft-github-policy-service agree
@wenkepaul can you open up an issue so the problem can be discussed?
/AzurePipeline run
I need to be able to set the FeatureFilters property without using init.
Do you mean the IsExternalInit
pattern will not resolve the init accessor issue for .NET Framework?
https://github.com/microsoft/FeatureManagement-Dotnet/blob/main/src/Microsoft.FeatureManagement/IsExternalInit.cs
@zhiyuanliang-ms For me in a 4.7.2
project that doesn't use the SDK style project, the IsExternalInit
does not solve the build error.
@zhiyuanliang-ms was this superseded by https://github.com/microsoft/FeatureManagement-Dotnet/pull/450 ?
@zhiyuanliang-ms was this superseded by #450 ?
@jimmyca15 I think, yes.
@wenkepaul I will close this PR. If you think the current solution still cannot meet your need, feel free to open an issue to track it.
I'm working on a project which doesn't use IServiceCollection or C# 9, but would benefit from using this library. In order to do so, I need to be able to set the FeatureFilters property without using
init
. This PR addsEnumerable<IFeatureFilterMetadata>
andIEnumerable<ISessionManager>
as optional parameters to the FeatureManager constructor and uses their existingEnumerable.Empty
as a fallback.