Open zhiyuanliang-ms opened 3 months ago
The test doesn't appear to be validating what it intends to. Ensuring something is in the cache does not check whether the filter calculates the window again or not.
@jimmyca15 In the latest commit, I added an internal property for the timewindow filter to track how many times recurring time window is re-calculated. What do you think?
This PR goes after PR #452
@jimmyca15 In the latest commit, I added an internal property for the timewindow filter to track how many times recurring time window is re-calculated. What do you think?
@zhiyuanliang-ms too invasive. Can we pass a custom implementation of IMemoryCache and check whenever memorycache.Set is called?
Can we pass a custom implementation of IMemoryCache and check whenever memorycache.Set is called?
@jimmyca15 Updated in 5da2d7d
Why this PR?
Added testcases to check whether the cache of time window filter cached the correct closest active recurring time window start.
https://github.com/microsoft/FeatureManagement-Dotnet/pull/266#discussion_r1593335729