microsoft / FeatureManagement-Dotnet

Microsoft.FeatureManagement provides standardized APIs for enabling feature flags within applications. Utilize this library to secure a consistent experience when developing applications that use patterns such as beta access, rollout, dark deployments, and more.

MIT License

1.05k stars 115 forks source link

Update README to emphasize built-in filters are add automatically and adjust wording #448

Closed zhiyuanliang-ms closed 6 months ago

zhiyuanliang-ms commented 6 months ago

Why this PR?

447

https://github.com/Azure/azure-sdk-for-java/pull/40093#discussion_r1596958545

Also include a small change to remove an unused reference in this PR

Visible changes

Update README

Remove an unused reference

rossgrambo commented 6 months ago

Should we update the release notes as well to call this a breaking change? Or adjust the AddFeatureFilter to TryAdd instead of Add and do a patch?

zhenlan commented 6 months ago

This is not intended breaking change (I suppose). If so, we should fix it ASAP. Adding it to the release notes will make it sound intentional.

zhiyuanliang-ms commented 6 months ago

This is not intended breaking change (I suppose). If so, we should fix it ASAP. Adding it to the release notes will make it sound intentional.

@zhenlan I have discussed with Jimmy. I will fix it ASAP.