search

microsoft / FeatureManagement-Dotnet

Microsoft.FeatureManagement provides standardized APIs for enabling feature flags within applications. Utilize this library to secure a consistent experience when developing applications that use patterns such as beta access, rollout, dark deployments, and more.
MIT License
1.05k stars 115 forks source link

Activity Based TargetingId Persistance #467

Closed rossgrambo closed 4 months ago

rossgrambo commented 5 months ago

Why this PR?

  1. Switches our Middleware and Initializer to use Activity.Baggage instead of HttpContext.Items to store Targeting information.
  2. Removes the Microsoft.FeatureManagement.ApplicationInsights.AspNetCore package

Visible Changes

The Microsoft.FeatureManagement.ApplicationInsights.AspNetCore will no longer be a nuget package deployed. The initializer has moved to Microsoft.FeatureManagement.ApplicationInsights.

Migrating

Developers using the initializer will need to change their using statement from

using Microsoft.FeatureManagement.ApplicationInsights.AspNetCore

to

using Microsoft.FeatureManagement.ApplicationInsights

There are no changes to the line that adds the initializer or anywhere else. This line stays:

builder.Services.AddSingleton<ITelemetryInitializer, TargetingTelemetryInitializer>();
jimmyca15 commented 4 months ago

Removes the Microsoft.FeatureManagement.ApplicationInsights.AspNetCore package

I don't see any files removed in the diff

rossgrambo commented 4 months ago

Updated to remove Microsoft.FeatureManagement.Telemetry.ApplicationInsights.AspNetCore

rossgrambo commented 4 months ago

Any other concerns?