search

microsoft / FluentDarkModeKit

A library for backporting Dark Mode in iOS
MIT License
1.63k stars 125 forks source link

Clean up copyrights #14

Closed imWildCat closed 4 years ago

imWildCat commented 4 years ago

Remove unnecessary lines of header comments.

li-bei commented 4 years ago

I think we will not use "Microsoft Inc." eventually. May be we can delay this work till public process?

icodesign commented 4 years ago

Should we change to Microsoft Corporation?

BTW, should we also include MIT in the header?

icodesign commented 4 years ago

Sample from VSCode:

/*---------------------------------------------------------------------------------------------
 *  Copyright (c) Microsoft Corporation. All rights reserved.
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/

What about just copying it?

imWildCat commented 4 years ago

Sample from VSCode:

/*---------------------------------------------------------------------------------------------
 *  Copyright (c) Microsoft Corporation. All rights reserved.
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/

What about just copying it?

Good idea.

And how about this way? https://github.com/OfficeDev/ui-fabric-ios/blob/master/OfficeUIFabric/Badge%20Field/MSBadgeField.swift

//
//  Copyright (c) Microsoft Corporation. All rights reserved.
//  Licensed under the MIT License.
//
li-bei commented 4 years ago

Sample from VSCode:

/*---------------------------------------------------------------------------------------------
 *  Copyright (c) Microsoft Corporation. All rights reserved.
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/

What about just copying it?

Good idea.

And how about this way? https://github.com/OfficeDev/ui-fabric-ios/blob/master/OfficeUIFabric/Badge%20Field/MSBadgeField.swift

//
//  Copyright (c) Microsoft Corporation. All rights reserved.
//  Licensed under the MIT License.
//

https://github.com/microsoft/CorrelationVector-Swift

This project use

//
//  Copyright (c) Microsoft Corporation. All rights reserved.
//  Licensed under the MIT License.
//

too.

icodesign commented 4 years ago

Both looks good to me. Let's go with the latter one which is more compatible with our existing ones.